From 5494f59c52f2637882658021311d0101ba565b75 Mon Sep 17 00:00:00 2001
From: Adam Blank <blank@caltech.edu>
Date: Mon, 21 Oct 2024 16:46:22 +0000
Subject: [PATCH] autocommit
---
08/jokes.py | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/08/jokes.py b/08/jokes.py
index 6b865ed..cf229f1 100644
--- a/08/jokes.py
+++ b/08/jokes.py
@@ -2,11 +2,11 @@ from joke_types import Joke
from joke_library import get_n_jokes, rate_joke, tell_joke
-def get_average_joke_rating(ratings: dict[int, int]) -> float:
- ...
+def get_average_joke_rating(ratings: dict[int, int]):
+ return ...
-def find_best_joke(jokes: dict[int, Joke], joke_ratings: dict[int, int]) -> Joke | None:
+def find_best_joke(jokes: dict[int, Joke], joke_ratings: dict[int, int]):
best_joke_id: int = -1
...
@@ -14,7 +14,7 @@ def find_best_joke(jokes: dict[int, Joke], joke_ratings: dict[int, int]) -> Joke
return jokes_by_id[best_joke_id]
-def tell_jokes(n: int = 3) -> tuple[dict[int, Joke], dict[int, int]]:
+def tell_jokes(n: int = 3):
jokes = get_n_jokes(n)
# Make a dictionary of jokes keyed by id
@@ -37,6 +37,4 @@ print()
print("The average rating you gave was..." +
str(get_average_joke_rating(joke_ratings)))
print("The best joke was...")
-best_joke = find_best_joke(jokes_by_id, joke_ratings)
-assert best_joke is not None
-tell_joke(best_joke)
+tell_joke(find_best_joke(jokes_by_id, joke_ratings))
--
GitLab