From 2df9f10ea520897ee35be7150d3189509a8bc13a Mon Sep 17 00:00:00 2001 From: Antonio Caceres <antonio@antonio-caceres.com> Date: Tue, 15 Oct 2024 13:40:13 -0700 Subject: [PATCH] Remove Final from constants in src/ files. --- src/morse_engine.py | 11 +++++------ src/prox_pulse.py | 6 +++--- src/pulse.py | 7 +++---- src/symbols.py | 4 +--- 4 files changed, 12 insertions(+), 16 deletions(-) diff --git a/src/morse_engine.py b/src/morse_engine.py index c47d477..31ecb44 100644 --- a/src/morse_engine.py +++ b/src/morse_engine.py @@ -1,16 +1,15 @@ import time -from typing import Final from src import morse_code from .abstract import LEDController, TouchSensor, ProximitySensor # Constants (Keep same or tests will break) -THRESHOLD: Final[int] = 75 -UNIT_TIME: Final[float] = 0.24 +THRESHOLD: int = 75 +UNIT_TIME: float = 0.24 -RED : Final[tuple[int, int, int]] = (255, 0, 0) -YELLOW: Final[tuple[int, int, int]] = (220, 160, 0) -GREEN : Final[tuple[int, int, int]] = (0, 255, 0) +RED : tuple[int, int, int] = (255, 0, 0) +YELLOW: tuple[int, int, int] = (220, 160, 0) +GREEN : tuple[int, int, int] = (0, 255, 0) # Legacy ham radio license requirement # - 0.24 sec unit time (5 words per minute) diff --git a/src/prox_pulse.py b/src/prox_pulse.py index 4ec40c1..90cf5ca 100644 --- a/src/prox_pulse.py +++ b/src/prox_pulse.py @@ -2,10 +2,10 @@ import time from .pulse import pulse from .abstract import LEDController, ProximitySensor -THRESHOLD = 75 +THRESHOLD: int = 75 -RED = (150, 10, 10) -GREEN = (30, 100, 10) +RED: tuple[int, int, int] = (150, 10, 10) +GREEN: tuple[int, int, int] = (30, 100, 10) def prox_pulse(px: LEDController, color: tuple[int, int, int], prox: int) -> None: diff --git a/src/pulse.py b/src/pulse.py index ebfbe61..ca61fa2 100644 --- a/src/pulse.py +++ b/src/pulse.py @@ -1,11 +1,10 @@ import time -from typing import Final from .abstract import LEDController -THRESHOLD: Final[int] = 75 -BLUE: Final[tuple[int, int, int]] = (0, 0, 255) -TIME: Final[int] = 1 +THRESHOLD: int = 75 +BLUE: tuple[int, int, int] = (0, 0, 255) +TIME: int = 1 def pulse(px: LEDController, color: tuple[int, int, int], duration: float): diff --git a/src/symbols.py b/src/symbols.py index 11ab20c..070b2c1 100644 --- a/src/symbols.py +++ b/src/symbols.py @@ -1,6 +1,4 @@ -from typing import Final - -MORSE_SYMBOL_TO_LETTER: Final[dict[str, str]] = { +MORSE_SYMBOL_TO_LETTER: dict[str, str] = { ".-": "A", "-...": "B", "-.-.": "C", -- GitLab