From 5856dcdffe66b21127f9236c60304ee25fd08e6a Mon Sep 17 00:00:00 2001
From: Antonio Caceres <antonio@antonio-caceres.com>
Date: Fri, 11 Oct 2024 16:13:30 -0700
Subject: [PATCH] Rename translate_complete_morse_symbol to append_morse_symbol
and fix LHS/RHS output accordingly.
---
src/morse_code.py | 2 +-
...se_symbol.py => test_append_morse_symbol.py} | 17 +++++++++--------
2 files changed, 10 insertions(+), 9 deletions(-)
rename tests/0.D/{test_translate_complete_morse_symbol.py => test_append_morse_symbol.py} (63%)
diff --git a/src/morse_code.py b/src/morse_code.py
index 732430b..8613a3f 100644
--- a/src/morse_code.py
+++ b/src/morse_code.py
@@ -1,7 +1,7 @@
from .symbols import MORSE_SYMBOL_TO_LETTER, InvalidSymbolError
-def translate_complete_morse_symbol(message, symbol):
+def append_morse_symbol(message, symbol):
"""
Decodes a Morse code symbol and appends the corresponding character to the
message.
diff --git a/tests/0.D/test_translate_complete_morse_symbol.py b/tests/0.D/test_append_morse_symbol.py
similarity index 63%
rename from tests/0.D/test_translate_complete_morse_symbol.py
rename to tests/0.D/test_append_morse_symbol.py
index c572074..c98c8c1 100644
--- a/tests/0.D/test_translate_complete_morse_symbol.py
+++ b/tests/0.D/test_append_morse_symbol.py
@@ -1,6 +1,6 @@
import pytest
-from src.morse_code import translate_complete_morse_symbol
+from src.morse_code import append_morse_symbol
from src.symbols import InvalidSymbolError
from tests.helpers.translate_symbol_data import SINGLE_SYMBOL_TESTS
from tests.helpers.naming import apply_names
@@ -9,24 +9,24 @@ from tests.helpers.naming import apply_names
@pytest.mark.parametrize(
"seq, msg, expected",
apply_names(
- "translate_complete_morse_symbol", [True, True, False], SINGLE_SYMBOL_TESTS
+ "append_morse_symbol", [True, True, False], SINGLE_SYMBOL_TESTS
),
)
def test_add_random(seq, msg, expected):
if expected is None:
with pytest.raises(InvalidSymbolError):
- result = translate_complete_morse_symbol(msg, seq)
+ append_morse_symbol(msg, seq)
else:
- result = translate_complete_morse_symbol(msg, seq)
+ result = append_morse_symbol(msg, seq)
assert (
- result == expected
+ expected == result
), "a valid morse code symbol wasn't translated correctly"
@pytest.mark.parametrize(
"msg, expected",
apply_names(
- "translate_complete_morse_symbol",
+ "append_morse_symbol",
[True, False],
[
("JUMPOUTTHEHOUSE", "JUMPOUTTHEHOUS"),
@@ -40,5 +40,6 @@ def test_add_random(seq, msg, expected):
),
)
def test_delete(msg, expected):
- result = translate_complete_morse_symbol(msg, "......")
- assert result == expected
+ result = append_morse_symbol(msg, "......")
+ assert expected == result, ("the delete symbol was not translated correctly; "
+ "check src/symbols.py for the morse code mapping")
--
GitLab