GitLab

This lab took me about ~1 hour 15 min, but most of my time was spent figuring out why rotation didn't work(I didn't have the transpose changes) and not realizing that the characters were stored in little endian format in the image. Here's my feedback:

1. The example code to iterate through a 2d array uses the syntax array.length[0] which should be array[0].length
2. I think the phrasing "snake through the array" in the description for decodeText() is a bit misleading. For some reason, I thought this meant go right to left on the first row, left to right on the second, and so on. I think it would be much simpler just to say "iterate through the array"
3. It took me a while to realize that the characters are stored in little endian format (least significant bit first) in the image, and I think it would help if the spec mentioned that, because it wasn't super obvious to me at first that I would have to flip bit ordering (why is it stored in this order in the first place?)
4. This is pedantic, but the description of transpose() should say "which is a reflection of," not "which is a reflect of"

Additionally, my repo wasn't able to find spaceElephants.hidden.png when running the B level tests.

@ddimino these are all valid imo

@ddimino and 'reflect' should still say 'transpose' in the spec

@amathuku was you 3rd bullet in reference to hide text or decode text?

@ddimino Technically it's in reference to both, but I ran into the issue when writing decode text. Once I realized the characters were little endian, it wasn't too bad to change hide text to behave the same way.

@ddimino if these are all fixed now, please close this issue -- if not, what is left to fix?

@blank sorry yes it's done!

closed