Skip to content

GitLab

  • Menu
    • Projects Groups Snippets
      Help
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • P project03
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • cs2-20wi
  • project03
  • Merge requests
  • !1

An error occurred while fetching the assigned milestone of the selected merge_request.
Merged
Created 4 years ago by Archie Shahidullah@archie:expressionless:Developer

Review Tests for Project 3

  • Overview 33
  • Commits 14
  • Pipelines 7
  • Changes 8
All threads resolved

Closes #1, #2, #3, #5, #6, #7, #9

Fixed issues and added nodechecker to LinkedDeque

Edited 4 years ago by Archie Shahidullah
Request to merge tests into master
  • Download as
  • Email patches

  • Plain diff

Pipeline #36467 canceled for d92faa87 on tests 4 years ago
Checking approval status

Merged by Ethan Ordentlich 4 years ago (Aug 14, 2020 9:40pm UTC) 4 years ago

The changes were merged into master with 39cdbef5

The source branch has been deleted

Pipeline #36478 canceled for 39cdbef5 on master 4 years ago

  • Adam Blank @blank assigned to @eordentl and unassigned @blank 4 years ago

    assigned to @eordentl and unassigned @blank

  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on an old version of the diff 4 years ago
    Resolved by Archie Shahidullah 4 years ago
  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on an old version of the diff 4 years ago
    Resolved by Ethan Ordentlich 4 years ago
  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on the diff 4 years ago
    Resolved by Ethan Ordentlich 4 years ago
  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on the diff 4 years ago
    Resolved by Ethan Ordentlich 4 years ago
  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on the diff 4 years ago
    Resolved by Ethan Ordentlich 4 years ago
  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on an old version of the diff 4 years ago
    Resolved by Ethan Ordentlich 4 years ago
  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on the diff 4 years ago
    Resolved by Ethan Ordentlich 4 years ago
  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on the diff 4 years ago
    Resolved by Ethan Ordentlich 4 years ago
  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on an old version of the diff 4 years ago
    Resolved by Ethan Ordentlich 4 years ago
  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on an old version of the diff 4 years ago
    Resolved by Adam Blank 4 years ago
  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on an old version of the diff 4 years ago
    Resolved by Ethan Ordentlich 4 years ago
  • Adam Blank @blank added 1 commit 4 years ago

    added 1 commit

    • 7b779a3f - Apply suggestion to tests/edu/caltech/cs2/datastructures/CircularArrayFixedSizeQueueTests.java

    Compare with previous version

  • Ethan Ordentlich
    Ethan Ordentlich @eordentl · 4 years ago
    Maintainer

    Let's also add the issues this fixes to the description. See https://docs.gitlab.com/ee/user/project/issues/managing_issues.html#closing-issues-automatically.

  • Archie Shahidullah :expressionless: @archie added 1 commit 4 years ago

    added 1 commit

    • e3bf3030 - Apply suggestion to tests/edu/caltech/cs2/datastructures/ArrayDequeTests.java

    Compare with previous version

  • Archie Shahidullah :expressionless: @archie added 1 commit 4 years ago

    added 1 commit

    • f4dcb96d - Update CircularArrayFixedSizeQueueTests.java

    Compare with previous version

  • Archie Shahidullah :expressionless: @archie added 1 commit 4 years ago

    added 1 commit

    • 0681730f - fixed issues

    Compare with previous version

  • Archie Shahidullah :expressionless: @archie changed the description 4 years ago

    changed the description

  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on an old version of the diff 4 years ago
    Resolved by Ethan Ordentlich 4 years ago
  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on an old version of the diff 4 years ago
    Resolved by Ethan Ordentlich 4 years ago
  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on the diff 4 years ago
    Resolved by Ethan Ordentlich 4 years ago
  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on the diff 4 years ago
    Resolved by Ethan Ordentlich 4 years ago
  • Archie Shahidullah :expressionless: @archie added 1 commit 4 years ago

    added 1 commit

    • 656caae1 - Resolving new issues

    Compare with previous version

  • Ethan Ordentlich @eordentl resolved all threads 4 years ago

    resolved all threads

  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on an old version of the diff 4 years ago
    Resolved by Ethan Ordentlich 4 years ago
  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on an old version of the diff 4 years ago
    Resolved by Ethan Ordentlich 4 years ago
  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on an old version of the diff 4 years ago
    Resolved by Ethan Ordentlich 4 years ago
  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on an old version of the diff 4 years ago
    Resolved by Ethan Ordentlich 4 years ago
  • Ethan Ordentlich
    Ethan Ordentlich @eordentl · 4 years ago
    Maintainer

    Just small nits at this point - great job on these changes.

  • Archie Shahidullah :expressionless: @archie added 1 commit 4 years ago

    added 1 commit

    • d92faa87 - timeout tests and other fixes

    Compare with previous version

  • Archie Shahidullah :expressionless: @archie changed the description 4 years ago

    changed the description

  • Ethan Ordentlich @eordentl resolved all threads 4 years ago

    resolved all threads

  • Ethan Ordentlich
    Ethan Ordentlich @eordentl · 4 years ago
    Maintainer

    LGTM - @blank?

  • Adam Blank
    Adam Blank @blank · 4 years ago
    Owner

    :thumbsup:

  • Ethan Ordentlich @eordentl mentioned in commit 39cdbef5 4 years ago

    mentioned in commit 39cdbef5

  • Ethan Ordentlich @eordentl merged 4 years ago

    merged

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
Assignee
Ethan Ordentlich's avatar
Ethan Ordentlich
@eordentl
Assign to
0 Reviewers
None
Request review from
Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: tests

Menu

Projects Groups Snippets
Help