Skip to content

GitLab

  • Menu
    • Projects Groups Snippets
      Help
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • P project08
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • cs2-20wi
  • project08
  • Merge requests
  • !2

Merged
Created 4 years ago by Archie Shahidullah@archie:expressionless:Developer

Review Tests for Project 8

  • Overview 6
  • Commits 9
  • Pipelines 6
  • Changes 19
2 unresolved threads

Closes #2, #3, #4, #5, #6, #9, #10 Related to #7

There were a decent amount of changes (to interfaces and methods) to this one, so I'd appreciate a double check to make sure I didn't break anything or if there are any compatibility issues.

Edited 4 years ago by Ethan Ordentlich
Request to merge tests into master
  • Download as
  • Email patches

  • Plain diff

Pipeline #46660 canceled for d24edee8 on tests 4 years ago
Approval is optional

Merged by Ethan Ordentlich 4 years ago (Feb 25, 2021 7:22pm UTC) 4 years ago

The changes were merged into master with 183c06a4

The source branch has been deleted

Pipeline #46666 failed for 183c06a4 on master 4 years ago

  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on an old version of the diff 4 years ago
    Last updated by Archie Shahidullah 4 years ago
    src/edu/caltech/cs2/datastructures/BeaverMapsGraph.java
    2 2
    3 3 import com.google.gson.JsonElement;
    4 4 import com.google.gson.JsonParser;
    5 import edu.caltech.cs2.interfaces.IDeque;
    6 import edu.caltech.cs2.interfaces.IDictionary;
    7 import edu.caltech.cs2.interfaces.ISet;
    5 import edu.caltech.cs2.interfaces.*;
    • Ethan Ordentlich
      Ethan Ordentlich @eordentl · 4 years ago
      Maintainer

      No star imports (static tests)

    • Archie Shahidullah :expressionless: @archie changed this line in version 2 of the diff 4 years ago

      changed this line in version 2 of the diff

    • Archie Shahidullah
      Archie Shahidullah :expressionless: @archie · 4 years ago
      Author Developer

      Also fixed star import in Graph.java

    • Please register or sign in to reply
  • Ethan Ordentlich
    Ethan Ordentlich @eordentl started a thread on an old version of the diff 4 years ago
    Last updated by Archie Shahidullah 4 years ago
    tests/edu/caltech/cs2/project08/BeavermapTests.java
    252 290
    253 291 IDeque<Location> actualPath = bmg.dijkstra(start, target);
    254 292 List<Long> actualPathIDs = new ArrayList<>();
    255 293 if (actualPath != null) {
    • Ethan Ordentlich
      Ethan Ordentlich @eordentl · 4 years ago
      Maintainer

      #2 applies here, I believe

    • Archie Shahidullah
      Archie Shahidullah :expressionless: @archie · 4 years ago
      Author Developer

      This method just tests whether dijkstra actually produces a path without buildings, rather than checking it for correctness against the trace. It just uses the start and target locations from trace. So I just check for null to only check existing paths. Should I check it for correctness (since it's already done in the stress test)?

    • Ethan Ordentlich
      Ethan Ordentlich @eordentl · 4 years ago
      Maintainer

      You're thinking of #3 and testDijkstraIgnoreBuildings (thanks for adding that). This is a separate issue - if actualPath is null and there is an expected path, the failure will read "Found path... where there is none."

    • Archie Shahidullah :expressionless: @archie changed this line in version 3 of the diff 4 years ago

      changed this line in version 3 of the diff

    • Archie Shahidullah
      Archie Shahidullah :expressionless: @archie · 4 years ago
      Author Developer

      Also added some IDs to the error messages in DijkstraTest

    • Please register or sign in to reply
  • Archie Shahidullah :expressionless: @archie added 1 commit 4 years ago

    added 1 commit

    • b37e9e2b - Fix star imports

    Compare with previous version

  • Archie Shahidullah :expressionless: @archie added 1 commit 4 years ago

    added 1 commit

    • 5837873b - Fix issue 2

    Compare with previous version

  • Ethan Ordentlich @eordentl added 4 commits 4 years ago

    added 4 commits

    • 60e0af32 - Small updates
    • e8ac544e - Test updates for graphs
    • 5e8ef627 - Update marvel tests
    • 99890b19 - update beavermaps and dijkstra tests

    Compare with previous version

    Toggle commit list
  • Ethan Ordentlich @eordentl added 1 commit 4 years ago

    added 1 commit

    • 01e652a8 - error messages go brrr

    Compare with previous version

  • Archie Shahidullah :expressionless: @archie added 1 commit 4 years ago

    added 1 commit

    • d24edee8 - error messages go brrr again

    Compare with previous version

  • Ethan Ordentlich @eordentl changed the description 4 years ago

    changed the description

  • Ethan Ordentlich @eordentl mentioned in commit 183c06a4 4 years ago

    mentioned in commit 183c06a4

  • Ethan Ordentlich @eordentl merged 4 years ago

    merged

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
Assignee
Ethan Ordentlich's avatar
Ethan Ordentlich
@eordentl
Assign to
0 Reviewers
None
Request review from
Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Lock merge request
Unlocked
2
2 participants
Ethan Ordentlich
Archie Shahidullah
Reference: cs2-20wi/project08!2
Source branch: tests

Menu

Projects Groups Snippets
Help