tweaks: don't close a descriptor when its stream has already been closed

a5981ab0 · Benno Schulenberg · 807f5c2e · a5981ab0
Commit a5981ab0 authored 7 years ago by Benno Schulenberg
Hide whitespace changes
Inline Side-by-side

Showing

with 4 additions and 6 deletions
+4 -6
--- a/src/files.c
+++ b/src/files.c
@@ -704,13 +704,11 @@ int is_file_writable(const char *filename)
    if ((fd = open(full_filename, O_WRONLY | O_CREAT | O_APPEND, S_IRUSR |
 		S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | S_IWOTH)) == -1)
 	result = FALSE;
-    else {
-	if ((f = fdopen(fd, "a")) == NULL)
-	    result = FALSE;
-	else
-	    fclose(f);
+    else if ((f = fdopen(fd, "a")) == NULL) {
+	result = FALSE;
 	close(fd);
-    }
+    } else
+	fclose(f);

    free(full_filename);